[lang] Free ndarray memory on the base class#8764
Open
BernardoCovas wants to merge 2 commits intotaichi-dev:masterfrom
Open
[lang] Free ndarray memory on the base class#8764BernardoCovas wants to merge 2 commits intotaichi-dev:masterfrom
BernardoCovas wants to merge 2 commits intotaichi-dev:masterfrom
Conversation
|
Bernardo Covas seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
classes inheriting from Ndarray should have their memory released
BernardoCovas
force-pushed
the
ndarray_base_del
branch
from
809afbb to
d7adf0a
Compare
for more information, see https://pre-commit.ci
BernardoCovas
changed the title
hughperkins
added a commit
to Genesis-Embodied-AI/quadrants
that referenced
this pull request
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
classes inheriting from Ndarray should have their memory released
Issue: #8763
Brief Summary
ScalarNdarray implements del() to allow python to get rid of the allocated memory,
but other subclasses of Ndarray (like VectorNdarray() or MatrixNdarray()) don't implement the same behaviour.
Seems to me the del() method should be moved to the Ndarray class.
I tested this simple change and indeed it fixes the memory leak.
Walkthrough
If, instead:
Note
Move deletion logic to
Ndarray.__del__so all ndarray variants free device memory; remove subclass-specific__del__fromScalarNdarray.Ndarray.__del__to delete underlyingarrviart.prog.delete_ndarray(...)when runtime/program exist.ScalarNdarray.__del__; destruction is now handled centrally by base class for all ndarray subclasses.python/taichi/lang/_ndarray.pyto centralize deletion logic and add safety checks (impl/arr/runtime/progpresence).Written by Cursor Bugbot for commit 4e58132. This will update automatically on new commits. Configure here.